1
0
mirror of https://github.com/blawar/GLideN64.git synced 2024-06-25 22:09:35 +00:00

Fix some of PVS-Studio warnings.

This commit is contained in:
Sergey Lipskiy 2019-03-03 11:47:10 +07:00
parent 4a925e1490
commit 3704b37c3e
5 changed files with 11 additions and 8 deletions

View File

@ -462,7 +462,7 @@ typedef struct
typedef struct
{
s16 y, x;
u16 flag;
u16 flag;
s16 z;
} SWVertex;
@ -478,9 +478,10 @@ typedef void (*GBIFunc)( u32 w0, u32 w1 );
struct MicrocodeInfo
{
u32 address, dataAddress;
u16 dataSize;
u32 type;
u32 address = 0;
u32 dataAddress = 0;;
u16 dataSize = 0;
u32 type = NONE;
bool NoN = false;
bool Rej = false;
bool cullBoth = true;

View File

@ -192,6 +192,8 @@ void DisplayWindowMupen64plus::_readScreen2(void * _dest, int * _width, int * _h
return;
u8 *pBufferData = (u8*)malloc((*_width)*(*_height) * 4);
if (pBufferData == nullptr)
return;
u8 *pDest = (u8*)_dest;
#if !defined(OS_ANDROID) && !defined(OS_IOS)

View File

@ -49,7 +49,7 @@ private:
std::vector<RectCoords> m_vecRectCoords;
struct iRect {
s32 ulx, uly, lrx, lry;
s32 ulx = 0, uly = 0, lrx = 0, lry = 0;
};
iRect _getiRect(u32 w0, u32 w1) const;
iRect m_curRect;

View File

@ -598,6 +598,7 @@ void _calcTileSizes(u32 _t, TileSizes & _sizes, gDPTile * _pLoadTile)
u32 tileHeight = ((pTile->lrt - pTile->ult) & 0x03FF) + 1;
if (tileWidth == 1 && tileHeight == 1 &&
gDP.otherMode.cycleType == G_CYC_COPY &&
_pLoadTile != nullptr &&
_pLoadTile->loadType == LOADTYPE_BLOCK) {
const u32 ulx = _SHIFTR(RDP.w1, 14, 10);
const u32 uly = _SHIFTR(RDP.w1, 2, 10);

View File

@ -2277,9 +2277,8 @@ void F5INDI_MoveWord(u32 _w0, u32 _w1)
static
void F5INDI_SetOtherMode(u32 w0, u32 w1)
{
s32 AT = 0x80000000;
AT >>= _SHIFTR(w0, 0, 5);
u32 mask = u32(AT) >> _SHIFTR(w0, 8, 5);
u32 mask = (s32)0x80000000 >> _SHIFTR(w0, 0, 5);
mask >>= _SHIFTR(w0, 8, 5);
const u32 A0 = _SHIFTR(w0, 16, 3);
if (A0 == 0) {