MGislv/GLideN64
1
0
Fork 0
mirror of https://github.com/blawar/GLideN64.git synced 2024-07-02 09:03:37 +00:00
Code Issues Projects Releases Wiki Activity

Correct read from RDRAM in FrameBuffer::isValid

Browse Source 
Fixed out of bounds read in Pokemon Stadium 2.
This commit is contained in:
Sergey Lipskiy 2017-03-11 13:07:24 +07:00
parent 8ea0cddbec
commit 5d5bfcc147
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/FrameBuffer.cpp
View File

@ -261,11 +261,16 @@ bool FrameBuffer::isValid(bool _forceCheck) const
if (m_cleared) {
const u32 testColor = m_clearParams.fillcolor & 0xFFFEFFFE;
const u32 stride = m_width << m_size >> 1;
const u32 lry = _cutHeight(m_startAddress, m_clearParams.lry, stride);
if (lry == 0)
return false;
const u32 ci_width_in_dwords = m_width >> (3 - m_size);
const u32 start = (m_startAddress >> 2) + m_clearParams.uly * ci_width_in_dwords;
const u32 * dst = pData + start;
u32 wrongPixels = 0;
for (u32 y = m_clearParams.uly; y < m_clearParams.lry; ++y) {
for (u32 y = m_clearParams.uly; y < lry; ++y) {
for (u32 x = m_clearParams.ulx; x < m_clearParams.lrx; ++x) {
if ((dst[x] & 0xFFFEFFFE) != testColor)
++wrongPixels;