MGislv/GLideN64
1
0
Fork 0
mirror of https://github.com/blawar/GLideN64.git synced 2024-07-02 09:03:37 +00:00
Code Issues Projects Releases Wiki Activity

gSPInsertMatrix: fix insert fractional part if old value is negativ

Browse Source 
s32 integer = static_cast<s32>(-2.5f) = -2
GetFloatMatrixElement(static_cast<s16>(integer), 0x44) = -1,9993286030

Fix:
s32 integer = (-2.5f * 65535.0f) >> 16 = (163837) >> 16 = -3
GetFloatMatrixElement(static_cast<s16>(integer), 0x44) =
-2,999008163576715
This commit is contained in:
gizmo98 2018-07-17 17:11:26 +02:00 committed by Sergey Lipskiy
parent e0418c3c34
commit a6adf6308d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gSP.cpp
View File

@ -1593,13 +1593,13 @@ void gSPInsertMatrix( u32 where, u32 num )
if (where < 0x20) {
// integer elements of the matrix to be changed
const s16 integer = static_cast<s16>(pData[i ^ 1]);
const s32 fract = static_cast<s32>(gSP.matrix.combined[0][index + i] * 65536.0f);
gSP.matrix.combined[0][index + i] = GetFloatMatrixElement(integer, static_cast<u16>(fract&0xFFFF));
const u16 fract = GetIntMatrixElement(gSP.matrix.combined[0][index + i]).second;
gSP.matrix.combined[0][index + i] = GetFloatMatrixElement(integer, fract);
} else {
// fractional elements of the matrix to be changed
const s32 integer = static_cast<s32>(gSP.matrix.combined[0][index + i]);
const s16 integer = GetIntMatrixElement(gSP.matrix.combined[0][index + i]).first;
const u16 fract = pData[i ^ 1];
gSP.matrix.combined[0][index + i] = GetFloatMatrixElement(static_cast<s16>(integer), fract);
gSP.matrix.combined[0][index + i] = GetFloatMatrixElement(integer, fract);
}
}
}