MGislv/GLideN64
1
0
Fork 0
mirror of https://github.com/blawar/GLideN64.git synced 2024-07-02 09:03:37 +00:00
Code Issues Projects Releases Wiki Activity

gSPInsertMatrix remove (int) cast and use copysignf

Browse Source 
Fraction value gets lost if float is cast to int. Use copysignf to
transfer sign from fraction to newvalue.
This commit is contained in:
gizmo98 2018-05-31 10:17:30 +02:00 committed by Sergey Lipskiy
parent a8349418ce
commit bb00ed3f4f
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/gSP.cpp
View File

@ -1575,13 +1575,16 @@ void gSPInsertMatrix( u32 where, u32 num )
if ((where & 0x3) || (where > 0x3C))
return;
// integer elements of the matrix to be changed
if (where < 0x20) {
fraction = modff( gSP.matrix.combined[0][where >> 1], &integer );
gSP.matrix.combined[0][where >> 1] = (f32)((s16)_SHIFTR( num, 16, 16 ) + abs( (int)fraction ));
gSP.matrix.combined[0][where >> 1] = (f32)((s16)_SHIFTR( num, 16, 16 ) + abs( fraction ));
fraction = modff( gSP.matrix.combined[0][(where >> 1) + 1], &integer );
gSP.matrix.combined[0][(where >> 1) + 1] = (f32)((s16)_SHIFTR( num, 0, 16 ) + abs( (int)fraction ));
} else {
gSP.matrix.combined[0][(where >> 1) + 1] = (f32)((s16)_SHIFTR( num, 0, 16 ) + abs( fraction ));
}
// fractional elements of the matrix to be changed
else {
f32 newValue;
fraction = modff( gSP.matrix.combined[0][(where - 0x20) >> 1], &integer );
@ -1589,7 +1592,7 @@ void gSPInsertMatrix( u32 where, u32 num )
// Make sure the sign isn't lost
if ((integer == 0.0f) && (fraction != 0.0f))
newValue = newValue * (fraction / abs( (int)fraction ));
newValue = copysignf( newValue, fraction );
gSP.matrix.combined[0][(where - 0x20) >> 1] = newValue;
@ -1598,7 +1601,7 @@ void gSPInsertMatrix( u32 where, u32 num )
// Make sure the sign isn't lost
if ((integer == 0.0f) && (fraction != 0.0f))
newValue = newValue * (fraction / abs( (int)fraction ));
newValue = copysignf( newValue, fraction );
gSP.matrix.combined[0][((where - 0x20) >> 1) + 1] = newValue;
}